Replaced React.PropTypes reference with PropTypes

pushtell / react-bootstrap-date-picker

React-Bootstrap based date picker.

MIT License

347 stars 195 forks source link

Replaced React.PropTypes reference with PropTypes #133

Closed JonShort closed 7 years ago

JonShort commented 7 years ago

Description

Replaced one area which was referencing React.PropTypes to use PropTypes from the prop-types library.

Motivation and Context

Should fix PropTypes warnings which this library causes in itself, and other projects.

How Has This Been Tested?

Test suite ran, PropTypes warning no longer appears in tests.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

capaj commented 7 years ago

why is this not merged yet?

JonShort commented 7 years ago

@wehriam Any chance this could be merged?

aanguswilliams commented 7 years ago

What is going on with this library, multiple PRs for bugs in master that haven't been merged

wehriam commented 7 years ago

@capaj and @aanguswilliams this is a community supported project. We do our best to address PRs and issues, but unfortunately have other professional obligations that preempt this work.

If you're interested in custom features or professional support for this project, please feel free to reach out to me directly.

I've added @JonShort as a contributor and humbly request he evaluate/merge this and other PRs as soon as he has a chance.

aanguswilliams commented 7 years ago

Apologies, I do 100% appreciate the contributions yourself and others have made to the open source community and understand there's no obligation to keep it up to date. Just wasn't sure what was going on with the timelines and was hoping to determine whether contributions were even still being taken. Thanks for your work.

capaj commented 7 years ago

@wehriam no problem, I was merely asking. I know activity in the PR thread increase the chance the PR will get the attentions from maintainers. Awesome that you've made @JonShort a contributor.