search

pushtell / react-bootstrap-date-picker

React-Bootstrap based date picker.
MIT License
346 stars 195 forks source link

Request - Update npm package to include latest changes #139

Open JonShort opened 7 years ago

JonShort commented 7 years ago

Table of Contents

Expected Behavior

Version of the npm package should be updated from 5.1.0 (current) to 5.1.1

Current Behavior

Currently, version 5.1.0 contains a few bugs, most notably the proptypes warnings that are thrown when the component is used in React 15.

Possible Solution

Updating the npm package to 5.1.1 will include the following bugfixes:

As a further enhancement, the updating of the npm package could be added to the CI build, triggered when version patched. But this is not necessary to address this issue.

Steps to Reproduce (for bugs)

N/A

Context

This component is throwing proptypes warnings in unit tests & development in projects me & my team are working on.

I am also aware that members of the community have had to resort to using their own forks to fix the bugs associated with minDate and maxDate.

Your Environment

N/A

noushad-pp commented 7 years ago

When will this npm package be upadated?

vivek1623 commented 7 years ago

plz fix it soon, i am facing same issues.

juanpaco commented 7 years ago

React 16 has landed, and the PropTypes issue prevents upgrading to React 16.

aanguswilliams commented 7 years ago

@wehriam is there anything we can do to help get these fixes published?

JonShort commented 7 years ago

For those struggling with the PropTypes warnings, I've added a CI config to my fork of this repo to publish an npm package with the latest changes.

This is for my own personal use, and i recommend not using it, but if you really need to fix the propTypes warnings feel free to use my npm package.

I'm hoping it'll be a temporary solution for me.

flygis commented 7 years ago

Please update the npm package so we all can move on with our life. The wait has been long enough for this.

redheadedstep commented 7 years ago

Well, I just wasted 4 hours tracking down #131 only to discover that the npm package hasn't been updated from 5.1.0 to 5.1.1. Can you just run the command line, update npm, and save us all a lot of headache!?

Other than that, great tool and very easy to implement.

travellingprog commented 7 years ago

I know it's not an ideal solution, but we got past this by just pointing to the latest commit of this repo. In our package.json, we have react-bootstrap-date-picker set to "github:pushtell/react-bootstrap-date-picker#f622dc8872dd180324ba5d3c295d009848f5814b". An NPM or Yarn install will be able to understand that.

asazernik commented 6 years ago

@pushtell Have you seen this?

Crisfole commented 6 years ago

Bump. At very least we need min/max date bugfix.

filipetedim commented 6 years ago

Bump. It's literally running one line. Maybe something happened to @pushtell ?

winstonewert commented 6 years ago

Do we need to fork?

JonShort commented 6 years ago

Yeah unfortunately you'll need to fork it, or use one of the forks that others have made 👍

winstonewert commented 6 years ago

Has anyone tried to put together a fork which aims to supplant the original? Or is everyone just making a bunch of random forks?