search

pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.55k stars 182 forks source link

Rename Query.where #118

Closed artem-zinnatullin closed 9 years ago

artem-zinnatullin commented 9 years ago

Query.where -> Query.selection Query.whereArgs -> Query.selectionArgs

For better consistency with SQLiteDatabase#query() and ContentProvider#query().

But, actually where looks much more understandable than selection, especially for ContentProvider

@nikitin-da your opinion?

nikitin-da commented 9 years ago

I prefer where. Does only dbHelper and contentProvider use selection name? At low level dbHelper also translate it to where. %)

artem-zinnatullin commented 9 years ago

Hehe :) Okay, where

вт, 17 марта 2015, 0:43, Dmitrii Nikitin notifications@github.com:

I prefer where. Does only dbHelper and contentProvider use selection name? At low level dbHelper also translate it to where. %)

— Reply to this email directly or view it on GitHub https://github.com/pushtorefresh/storio/issues/118#issuecomment-81954969 .