search

pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.55k stars 182 forks source link

Rename affectedTables to changedTables #174

Closed artem-zinnatullin closed 9 years ago

artem-zinnatullin commented 9 years ago

@nikitin-da do you agree?

nikitin-da commented 9 years ago

No=) On my opinion, changed- it is when something took another value, but there are cases when value is the same. And affected that means we became unsure in table immutability. So, if we will only rename field, without additional checks, it will be more pleasant, but less correctly.

artem-zinnatullin commented 9 years ago

Hm, you are right, thank you for opinion :)

вс, 29 марта 2015, 19:13, Dmitrii Nikitin notifications@github.com:

No=) On my opinion, changed- it is when something took another value, but there are cases when value is the same. And affected that means we became unsure in table immutability. So, if we will only rename field, without additional checks, it will be more pleasant, but less correctly.

— Reply to this email directly or view it on GitHub https://github.com/pushtorefresh/storio/issues/174#issuecomment-87433255 .