search

pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.55k stars 182 forks source link

Kill nulls in Queries! #346

Closed artem-zinnatullin closed 9 years ago

artem-zinnatullin commented 9 years ago

Nulls everywhere in StorIO, that's good for performance, but not safe for users, I think that it's better to lose 1% of performance, but provide safety instead.

nikitin-da commented 9 years ago

Do you mean use final collections with addAll instead of assignment or something else?

artem-zinnatullin commented 9 years ago

Nope, I mean nulls in Queries and other classes

RawQuery rawQuery = new RawQuery.Builder()
  .query("SELECT * FROM tweets")
  .build();

rawQuery.args() == null; // -> true
rawQuery.observesTables() == null; //-> true
rawQuery.affectsTables() == null; // -> true