pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.55k stars 182 forks source link

Provide public API to ChangesBus to allow users subscribe to all changes in StorIO #446

Closed artem-zinnatullin closed 9 years ago

artem-zinnatullin commented 9 years ago

At the moment user can observe changes of particular tables (in StorIOSQLite) or particular Uris (in StorIOContentResolver).

I think it could be useful for users (at least for me and our current work project) to have an API that will allow to observe all changes without filtration, for example for logging and other purposes.

@nikitin-da thoughts? I remember that we discussed this several months ago and decided to provide only observeChanges(tables) and observeChanges(uris) to prevent users from EventBus-like code, but now I see usages for general observeChanges() API.

nikitin-da commented 9 years ago

Just for logging? Do you have other ideas why it may be helpful, listen entire db regardless of the tables?

artem-zinnatullin commented 9 years ago

You can dynamically decide what to filter and yes -> logging, but we will provide logging in some future release…

Rainer-Lang commented 9 years ago

Logging is essential. Very nice - I'm looking forward.

For now I'm using DBFlow, but storio is getting better and better - and for me it's important that I can use rxjava.

artem-zinnatullin commented 9 years ago

Sure, logging is essential but we'll provide it as separate feature #79.