search

pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.55k stars 182 forks source link

Add info about "key" column into documentation for StorIOSQLite annotations! #505

Open artem-zinnatullin opened 9 years ago

lectricas commented 7 years ago

good idea! Error:(10, 8) error: Class marked with StorIOSQLiteType annotation should have at least one KEY field marked with StorIOSQLiteColumn annotation is really confusing

artem-zinnatullin commented 7 years ago

Isn't it kinda straightforward error message? :)

On Wed, Dec 14, 2016, 16:29 alexey polusov notifications@github.com wrote:

good idea! Error:(10, 8) error: Class marked with StorIOSQLiteType annotation should have at least one KEY field marked with StorIOSQLiteColumn annotation is really confusing

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/pushtorefresh/storio/issues/505#issuecomment-267033824, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7B3HkwpwG3kNhKLduQUW8aNwBcGzT-ks5rH-9UgaJpZM4F5JDF .

lectricas commented 7 years ago

Nope. I was like: What the hack is this key mean? A door key? Ctr+f on readme didn't help me. Then I figured it out by crawling the sample app. Consider adding "primary" word or something. You did it well on "StorIOSQLiteColumn" btw :D

artem-zinnatullin commented 7 years ago

Ahaha, got it :) Can you please make a PR then?

On Wed, Dec 14, 2016, 19:13 alexey polusov notifications@github.com wrote:

Nope. I was like: What the hack is this key mean? A door key? Ctr+f on readme didn't help me. Then I figured it out by crawling the sample app. Consider adding "primary" word or something. You did it well on "StorIOSQLiteColumn" btw :D

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/pushtorefresh/storio/issues/505#issuecomment-267076506, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7B3DhCfbKNcbR9T-uY6TZT4P-YXlQxks5rIBWWgaJpZM4F5JDF .