pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.55k stars 182 forks source link

for db-upgrade #527

Closed Rainer-Lang closed 9 years ago

Rainer-Lang commented 9 years ago

In SampleApp there is: public DbOpenHelper(@NonNull Context context)

but shouldn't it be: public DatabaseHelper(Context context, String dbName, null, int dbVersion)?

Or should be the db-version-number be provided directly with a constant?

public DbOpenHelper(@NonNull Context context) {
    super(context, Constant.DB_NAME_STORIO, null, Constant.DB_VERSION);
}

What's the preferred way with StorIO?

artem-zinnatullin commented 9 years ago

What's the preferred way with StorIO?

It does not related to StorIO at all :)

Usually we use constructor with just context in our projects.