pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.55k stars 182 forks source link

Unit Tests for improved test coverage #571

Closed mfarid closed 8 years ago

mfarid commented 8 years ago

Will it be helpful if I write some unit tests for certain modules to improve overall tested code coverage.

artem-zinnatullin commented 8 years ago

@mfarid sure! You can start with small PR and few tests!

mfarid commented 8 years ago

@artem-zinnatullin Thanks a lot for quick response, I will start with a small PR with few tests, just as you suggested.

artem-zinnatullin commented 8 years ago

@mfarid great! Just curious with what class do you want to start? :smile:

mfarid commented 8 years ago

@artem-zinnatullin I have not identified any specific class as of now, if you would like me to target something specific, please let me know. Otherwise, once I start with some tests I will update this ticket with the same.

artem-zinnatullin commented 8 years ago

I have a solution! We have tests coverage which seems to be broken for last month because flucking Gradle things, let me fix test coverage measurement and then we'll see what classes need more tests, okay?

On Mon, Dec 14, 2015, 07:49 Mohd Farid notifications@github.com wrote:

@artem-zinnatullin https://github.com/artem-zinnatullin I have not identified any specific class as of now, if you would like me to target something specific, please let me know. Otherwise, once I start with some tests I will update this ticket with the same.

— Reply to this email directly or view it on GitHub https://github.com/pushtorefresh/storio/issues/571#issuecomment-164342263 .

@artem_zin

mfarid commented 8 years ago

Sounds great, thanks.

artem-zinnatullin commented 8 years ago

@mfarid yay! You can now pull the repository and run ci.sh and then find Jacoco reports about test coverage in module/build/reports/ for each module!

mfarid commented 8 years ago

Thanks @artem-zinnatullin I appreciate it. Ii will start with a small module and send out a PR to you soon.

artem-zinnatullin commented 8 years ago

Great, thanks @mfarid! You can start even with one or two tests so code review will be fast :)

artem-zinnatullin commented 8 years ago

Looks like this one can be closed :)