search

pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.55k stars 182 forks source link

Proguard and StorIO #773

Closed Tooto closed 7 years ago

Tooto commented 7 years ago

Hi! Should i setup some proguard rules? I have this error: Warning:com.pushtorefresh.storio.operations.internal.OnSubscribeExecuteAsBlockingCompletable: can't find superclass or interface rx.Completable$OnSubscribe

artem-zinnatullin commented 7 years ago

I guess you don't use RxJava. StorIO does not use reflection that requires proguard settings.

On Mon, Mar 27, 2017, 14:42 Igor Glushkov notifications@github.com wrote:

Hi! Should i setup some proguard rules? I have this error: Warning:com.pushtorefresh.storio.operations.internal.OnSubscribeExecuteAsBlockingCompletable: can't find superclass or interface rx.Completable$OnSubscribe

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pushtorefresh/storio/issues/773, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7B3MBQQf9R_5hMTB-LV_jVeyK_vhGKks5rp6CJgaJpZM4MqJhc .

nikitin-da commented 7 years ago

I guess the only issue we can meet with obfuscation is the false negative result in this check Do you have explicit rxjava dependency?

artem-zinnatullin commented 7 years ago

AFAIK, ProGuard handles such class lookups.

On Tue, Mar 28, 2017, 11:40 Dmitrii Nikitin notifications@github.com wrote:

I guess the only issue we can meet with obfuscation is the false negative result in this https://github.com/pushtorefresh/storio/blob/9f93ee905e70d6c89290e094a92ddcdb57df0e45/storio-common/src/main/java/com/pushtorefresh/storio/internal/Environment.java#L22 check Do you have explicit rxjava dependency?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/pushtorefresh/storio/issues/773#issuecomment-289702646, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7B3E8lOXo7M8gpzQcPkKCtQPRWLIIcks5rqMeOgaJpZM4MqJhc .

artem-zinnatullin commented 7 years ago

I'm closing the issue, feel free to comment!

karntrehan commented 7 years ago

For anybody facing this issue. Please use the following line in your proguard-rules.pro -dontwarn com.pushtorefresh.storio.**