search

pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.55k stars 182 forks source link

Lowering minSdkVersion to 9 for further compatibility #795

Closed Thore1954 closed 7 years ago

Thore1954 commented 7 years ago

This is a great lib and I use it in most of my projects except the one's the client asks to be compatible down to Android 2.3! Any idea on lowering the minSdkVersion to API 9 somewhere in the future? I don't think it takes much effort since most everything in the lib is already back compatible.

artem-zinnatullin commented 7 years ago

Well, such a commitment will definitely tie our hands for future releases..

I belive you can override our minSdk in your project setup!

On Tue, Jun 6, 2017, 03:14 Thore1954 notifications@github.com wrote:

This is a great lib and I use it in most of my projects except the one's the client asks to be compatible down to Android 2.3! Any idea on lowering the minSdkVersion to API 9 somewhere in the future? I don't think it takes much effort since most everything in the lib is already back compatible.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/pushtorefresh/storio/issues/795, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7B3ES4rINqL-NP6c_Cz_ohL2zAoYulks5sBJnxgaJpZM4Nwtwz .

Thore1954 commented 7 years ago

Yes, you were right. I managed to add the storio-common and storio-sqlite modules directly into my project and with a few modifications on gradle files it worked on Android 2.3! I still don't understand why lowering the minSdkVersion will make problem on this Non-UI library.

artem-zinnatullin commented 7 years ago

I managed to add the storio-common and storio-sqlite modules directly into my project and with a few modifications on gradle files it worked on Android 2.3!

That's not what I meant 😨

You should be able to override StorIO/s minSdk just by adding something like this in your AndroidManifest.xml:

<uses-sdk 
  tools:overrideLibrary="com.pushtorefresh.storio.common" 
  tools:overrideLibrary="com.pushtorefresh.storio.sqlite" />

I still don't understand why lowering the minSdkVersion will make problem on this Non-UI library.

Well, it might look easy now, but we may use some SQLiteDatabase/ContentResolver methods that are API level dependent and in such a case we'll be in a bad situation with low minSdkVersion.