pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.

Apache License 2.0

2.54k stars 182 forks source link

Update Gradle 3.5 → 4.2.1. #825

Closed artem-zinnatullin closed 7 years ago

artem-zinnatullin commented 7 years ago

Changelog https://github.com/gradle/gradle/releases

artem-zinnatullin commented 7 years ago

Could not find or load main class org.gradle.wrapper.GradleWrapperMain

Hm, lemme see, I thought it was only my local problem because I used Linux subsystem on Windows

nikitin-da commented 7 years ago

the same problem on mac

artem-zinnatullin commented 7 years ago

Interesting, I've definitely used 4.2.1 at work, hmm. Either they've updated wrapper jar without new release and broke something or it's my Windows machine.

@nikitin-da can you please try to update on mac locally on master branch? ./gradlew wrapper --gradle-version 4.2.1?

For now I'll update it to 4.2, works fine for me.

artem-zinnatullin commented 7 years ago

dafq

Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain

nikitin-da commented 7 years ago

After local update all works fine https://github.com/pushtorefresh/storio/commit/e63ee35e2cadf60c4cc3e9b3bbf3964917c0bd66

artem-zinnatullin commented 7 years ago

Yeah I think it's Windows uhhhhh, I'll update from my mac then, thanks man!

artem-zinnatullin commented 7 years ago

826

codecov-io commented 7 years ago

Codecov Report

Merging #825 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          91       91           
  Lines        2707     2707           
  Branches      305      305           
=======================================
  Hits         2637     2637           
  Misses         38       38           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6120229...cfc8efc. Read the comment docs.