pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.54k stars 182 forks source link

Don't build/test debug builds of library modules. #831

Closed artem-zinnatullin closed 7 years ago

artem-zinnatullin commented 7 years ago

Looking at CI logs I've noticed that we're building and testing debug build type of library modules and then do the same for release build type.

There is no need for that since we don't have build-type specific code, so removing debug builds should speedup CI and save us some log output lines because we're slightly more than 10k atm and Travis only renders 10k lines in its UI, otherwise you have to look at raw log output.

artem-zinnatullin commented 7 years ago

Hah, so I did that in past already PR #473, but then for some reason removed it in PR #575

nikitin-da commented 7 years ago

Heh, for some reason? Is there a way to check coverage on the release build))?

artem-zinnatullin commented 7 years ago

Ah damn it, so we should not build release then :D

artem-zinnatullin commented 7 years ago

Btw, what's wrong with measuring coverage on release build? We don't run proguard on it

nikitin-da commented 7 years ago

It seems with jacoco classes will be compiled with debug information (line numbers) to allow for source code highlighting

should not build release then

:joy:

nikitin-da commented 7 years ago

debug information (line numbers)

Is it ok to keep this meta in release?

artem-zinnatullin commented 7 years ago

Ahhhhhhhh daaaamn wait, I'm afraid we do that anyway!!1 jacoco-android.gradle adds coverage to all build types

artem-zinnatullin commented 7 years ago

It would be super cool if you could check if our release aars contain jacoco calls, that would be facepalm.jpg

We can solve this, I see couple ways, but I need to sleep now

artem-zinnatullin commented 7 years ago

Ah, just in case, previous releases were done manually and I usually run ./gradlew clean uploadArchives which doesn't run tests (because I trusted our CI) and doesn't add jacoco tasks to graph, so previous releases most likely don't include jacoco

artem-zinnatullin commented 7 years ago

Easy solution to not include jacoco calls into released jars would be to change skip_cleanup: true to false in deploy section of travis.yml or add clean to Gradle tasks in release mode