search

pushtorefresh / storio

Reactive API for SQLiteDatabase and ContentResolver.
Apache License 2.0
2.54k stars 182 forks source link

Use environment variable to detect publishing state. #834

Closed artem-zinnatullin closed 7 years ago

artem-zinnatullin commented 7 years ago

Uhh damn Gradle, Travis and everything.

I wasn't able to use Gradle task graph analysis, so one way is to use env variable as I do here, another way is to always try to read release-related env variables for signing but I do find it more error prone and hard to debug in case if something will go wrong, current process will break build asap which is easier to debug

Sorry for so many PRs, but it's hard to test locally because CI has pretty different setup

codecov-io commented 7 years ago

Codecov Report

Merging #834 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #834   +/-   ##
=========================================
  Coverage     97.41%   97.41%           
  Complexity      791      791           
=========================================
  Files            91       91           
  Lines          2707     2707           
  Branches        305      305           
=========================================
  Hits           2637     2637           
  Misses           38       38           
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 46ac214...178f525. Read the comment docs.