pushtype / push_type

PushType is a modern, open source content management system for Ruby on Rails.
http://www.pushtype.org
Other
290 stars 32 forks source link

railties conflict for Rails 5.1 project #41

Closed bennypaulino closed 7 years ago

bennypaulino commented 7 years ago

There is no longer a hard limit on railties < 5.1 for devise. As seen here:

https://github.com/plataformatec/devise/blob/0fe308e7a77ff4f4e41228c04c109ce0178f4d4f/gemfiles/Gemfile.rails-5.1-stable.lock#L16

and here:

https://github.com/plataformatec/devise/blob/4beeca46c45dcb2fbc7513570dbc30dcbe3cc85a/devise.gemspec#L24

bundle install fails after adding gem 'push_type', '~> 0.11.0.beta.1' to the Gemfile, and running the command for bundle update yields the following:

Bundler could not find compatible versions for gem "railties":
  In Gemfile:
    push_type (~> 0.11.0.beta.1) was resolved to 0.11.0.beta.1, which depends on
      push_type_auth (= 0.11.0.beta.1) was resolved to 0.11.0.beta.1, which depends on
        devise (~> 4.2.1) was resolved to 4.2.1, which depends on
          railties (< 5.1, >= 4.1.0)

    rails (~> 5.1.0) was resolved to 5.1.0, which depends on
      railties (= 5.1.0)
aaronrussell commented 7 years ago

Thanks. I'll look in to this.

aaronrussell commented 7 years ago

PushType is ready to go on this, but we need Devise to release a new version: See plataformatec/devise#4525 - As soon as they release a new gem I can release ours.

In the meantime you can use the latest beta 0.11.0.beta.2 and add this to your gem file:

gem 'devise', git: 'https://github.com/plataformatec/devise.git', branch: 'master'
bennypaulino commented 7 years ago

Works a treat! I can have my cake and eat it too. Thanks, Aaron, for the provisional work-around!

aaronrussell commented 7 years ago

Cool, glad that worked. I'm going to keep this issue open just to remind me to release the gem once devise release their rails 5.1 version.

NotTheUsual commented 7 years ago

I'm still getting an error trying to set up a project like this. Gemfile:

gem 'push_type', '~> 0.11.0.beta.2'
gem 'devise', git: 'https://github.com/plataformatec/devise.git', branch: 'master'

Output

Bundler could not find compatible versions for gem "devise":
  In Gemfile:
    devise

    push_type (~> 0.11.0.beta.2) was resolved to 0.11.0.beta.2, which depends on
      push_type_auth (= 0.11.0.beta.2) was resolved to 0.11.0.beta.2, which depends on
        devise (~> 4.2.1)
ryenski commented 7 years ago

auth/push_type_auth.gemspec is locked to devise 4.2.1, which requires Rails<5.1.

Devise latest (4.3.0) has been updated updated to Rails<5.2. Is it possible to update the gemspec?

Would you like a PR? I did update my gemspec locally, but I'm not able to run the test suite due to the webpack limitation.

aaronrussell commented 7 years ago

@mysmallidea thanks for offering to help, although I'm already on this so no need on this occasion. New release should be out tonight.

aaronrussell commented 7 years ago

The new release is out now - v0.11.1 (skipped a version because I botched 0.11.0 previously and had to yank it). With the latest version there's no need to reference devise from github.