Open ryenski opened 6 years ago
I've just been away for a month so I haven't actually got a release out yet that is tested to work with 5.2, so maybe this is related, although that error looks a little odd. Seems to be trying to connect to the database as part of the create task, before it's even created the database 😛
First step is for me to get a 5.2 tested build released for you to use and see if this problem persists. If it does then there's something else going on.
Give me a few days and I'll let you know when a 5.2 build is ready.
Yeah it is odd, sorry I didn't take the time to test with 5.1. Mainly just wondering if anyone else had run into that.
A small update on this one. I've confirmed this bug does exists - it's not present in Rails 5.0.x or 5.1.x - so is something new in 5.2.
This part of the error stack suggests that it is the closure_tree
gem that is checking the database causing this issue:
from /Users/ryenski/.gem/ruby/2.4.1/gems/activerecord-5.2.0.rc1/lib/active_record/model_schema.rb:324:in `table_exists?'
from /Users/ryenski/.gem/ruby/2.4.1/gems/closure_tree-6.6.0/lib/closure_tree/support_flags.rb:21:in `order_is_numeric?'
from /Users/ryenski/.gem/ruby/2.4.1/gems/closure_tree-6.6.0/lib/closure_tree/support.rb:28:in `initialize'
from /Users/ryenski/.gem/ruby/2.4.1/gems/closure_tree-6.6.0/lib/closure_tree/has_closure_tree.rb:16:in `new'
from /Users/ryenski/.gem/ruby/2.4.1/gems/closure_tree-6.6.0/lib/closure_tree/has_closure_tree.rb:16:in `has_closure_tree'
Ref this code at closure_tree:
So I thought maybe this is an external issue so I created a plain old Rails app using closure tree (without PushType), but could not recreate the problem there.
So something specific about PushType is causing this to occur, but I'm a bit lost where to look next. I'll await the full Rails 5.2 release as maybe this is something that will get mopped up in the release candidates, but if not this will need deeper digging.
I'm unable to initialize a new database in an app when PushType is installed. This occurs with Rails 5.2; I haven't tried it yet with 5.1
Environment:
Steps to reproduce:
rails g push_type:node page body:wysiwyg
rails db:drop
. Database is dropped successfully.rails db:create
.Expected behavior: Database is created
Actual behavior:
ActiveRecord::NoDatabaseError
is raised.