clean helper usage in admin controller

pushtype / push_type

PushType is a modern, open source content management system for Ruby on Rails.

http://www.pushtype.org

Other

290 stars 32 forks source link

clean helper usage in admin controller #8

Closed ipmsteven closed 7 years ago

ipmsteven commented 8 years ago

Looks like the only thing break after removing helper PushType::Admin::Engine.helpers in AdminController is rendering node page( fields helper is needed when rendering a node page)

aaronrussell commented 7 years ago

Apologies for the delay in doing anything with this PR. I have just been doing some work with helpers in #23 and tested your change and found it broke a few things.

I'm planning a rewrite of the entire admin engine in the coming months so I'm not too bothered by including all the helpers here for now.

Thanks for the PR, but am closing this for now.

ipmsteven commented 7 years ago

ok, good to know :)