search

pushyrpc / pushy

Easy-as RPC. Zero-server RPC for Python and Java.
http://github.com/pushyrpc/pushy
45 stars 18 forks source link

Native SSH no longer used (0.5.2) on Windows #43

Closed jpenney closed 11 years ago

jpenney commented 11 years ago

The change to allow the use of the (now defunct) paramiko fork in #38 misbehaves badly if you don't have either paramiko or ssh installed, and blocks the use of the native ssh

Python 2.7.5 (default, May 20 2013, 00:18:41) 
[GCC 4.2.1 Compatible Apple LLVM 4.2 (clang-425.0.28)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import pushy
>>> import pushy.transport.ssh
>>> pushy.transport.ssh == pushy.transport.ssh.paramiko
True

Things still seem to work on Mac, but under Windows it causes this:

>>> pushy.connect('ssh:127.0.0.1')
[...]
AttributeError: 'module' object has to attribute 'SSHClient'

Since the ssh fork is no more, can #38 be reverted out?

axw commented 11 years ago

@jpenney Thanks for reporting this, and sorry for the regression. I can see the problem clearly now: pushy.transport.ssh is importing 'ssh', which is just importing itself (pushy.transport.ssh). Doh.

Yes, I'll revert this. There's no good reason for supporting 'ssh' anymore. For now, if you wish to work around it, you can pass "use_native=True" to pushy.connect.

axw commented 11 years ago

This should now be fixed. I've uploaded a new release to PyPI and launchpad. Thanks again.