Closed joelpurra closed 4 weeks ago
@berkanteber: only tested on Kodi v20.5.0. If you haven't seen any crashes on putio-kodi v3.1.0 on more recent Kodi versions, as you mentioned when closing #16, perhaps there's some other issue?
Seems like all asserts are stripped on v21 (or at least on my Kodi). That's why I assumed it's no longer an issue. If that's the case, it would be best to remove all asserts since they are misleading. But for now, let's just fix it.
If that's the case, it would be best to remove all asserts since they are misleading. But for now, let's just fix it.
Actually, it may be better to skip on subtitle-related errors.
@berkanteber: didn't know about this change in Kodi v21, but guess they see it as "production" mode. This assert is a valuable sanity check; removing it might lead to follow-up errors. Sure, skipping subtitles instead of crashing might be alright -- assuming that such future errors are merely intermittent.
Fixes #16.
See