search

putnam / binmerge

Tool to merge multiple bin/cue tracks into one. Great for redump.
GNU General Public License v2.0
340 stars 44 forks source link

Option to not add full path to cue sheet when using --split #12

Closed malvarenga123 closed 9 months ago

malvarenga123 commented 2 years ago

The issue was with my batch files.

putnam commented 2 years ago

Currently, the generation of the filenames is based on what you input to the program. It's a result of calling it with explicit full paths, rather than relative. You could maybe change directory before running it?

I could also see about adding some flag if it would improve the user experience. Can you clarify what your workflow looks like?

putnam commented 2 years ago

Just saw your edit -- it could still be an opportunity for improvement. Can you post your batch?

malvarenga123 commented 2 years ago

Sorry for the late reply. The batch file was simple

start "" /low %binmerge_path% --split %cue_name% %split_name%

%split_name% had the full path. After changing it to %~dpn1 it worked fine.

MestreLion commented 1 year ago

You could maybe change directory before running it?

This a good workaround, but not the best solution. How the output files are specified should not change the output CUE content.

Not adding paths to the BIN files in the CUE content is quite a consensus in communities that deal with CUE files, so I believe no additional flag is necessary, and this can be default behavior.

As for implementation, a simple os.path.basename(track_fn) when creating the CUE content is enough. I can happily provide a PR if you're interested

putnam commented 1 year ago

Yeah, I'm with you on that. Will adjust it.