putpat / rockstar

Rockstar is a wrapper for the audioscrobbler v2.0 (last.fm) web services. This gem includes scrobbling with the new api.
MIT License
82 stars 29 forks source link

load_info method and missing attributes for artist / track data #11

Closed zapnap closed 13 years ago

zapnap commented 13 years ago

It seems that the #images method on artist calls load_info, but this method doesn't exist on the artist class. A version of the method does exist on album (for getting album information of course), and appears to be called when :include_info => true is passed at initialization.

Is this a work in progress, with the idea that any model should be able to pass :include_info with initialization to do an API lookup and populate the model with data? It seems odd right now that, for example, when I initialize an artist, that there's no way for me to retrieve the mbid, url, or any other characteristics of the model other than the information I originally supplied.

Or am I missing some obvious way to do that? Thanks!

bitboxer commented 13 years ago

No, it's part of the original codebase I forked. I wanted to make that much nicer in a refactoring, but never got time to do it :( .

zapnap commented 13 years ago

Okay. I may take a crack at this later today or tomorrow (depending on time). Will shoot you a pull request if I make any progress.

bitboxer commented 13 years ago

Great!

zapnap commented 13 years ago

Just sent you a pull request ;-).

bitboxer commented 13 years ago

Just pulled it. Thanks for that!

Do you want to have write access to this repo? I would love to add you to the list of collaborators.

zapnap commented 13 years ago

Sure, whatever is easier for you. I don't want to pretend I've got tons of free time to work on it (I'm a bit overcommitted as it is!) but I'm happy to contribute any changes.

Time to release a new point release of the gem maybe?

bitboxer commented 13 years ago

A new release is uploaded right now :)

bitboxer commented 13 years ago

I want to add your name to the Readme. What should I write? Just zapnap? Or do you prefer your real name?

zapnap commented 13 years ago

Either / or is fine. My name is Nick Plante :).