Closed zapnap closed 13 years ago
No, it's part of the original codebase I forked. I wanted to make that much nicer in a refactoring, but never got time to do it :( .
Okay. I may take a crack at this later today or tomorrow (depending on time). Will shoot you a pull request if I make any progress.
Great!
Just sent you a pull request ;-).
Just pulled it. Thanks for that!
Do you want to have write access to this repo? I would love to add you to the list of collaborators.
Sure, whatever is easier for you. I don't want to pretend I've got tons of free time to work on it (I'm a bit overcommitted as it is!) but I'm happy to contribute any changes.
Time to release a new point release of the gem maybe?
A new release is uploaded right now :)
I want to add your name to the Readme. What should I write? Just zapnap? Or do you prefer your real name?
Either / or is fine. My name is Nick Plante :).
It seems that the #images method on artist calls load_info, but this method doesn't exist on the artist class. A version of the method does exist on album (for getting album information of course), and appears to be called when :include_info => true is passed at initialization.
Is this a work in progress, with the idea that any model should be able to pass :include_info with initialization to do an API lookup and populate the model with data? It seems odd right now that, for example, when I initialize an artist, that there's no way for me to retrieve the mbid, url, or any other characteristics of the model other than the information I originally supplied.
Or am I missing some obvious way to do that? Thanks!