search

putridparrot / RustUnits

Units of conversion for Rust
MIT License
10 stars 0 forks source link

missing volume units #1

Closed happysalada closed 1 year ago

happysalada commented 1 year ago

hey, there are a couple of missing volume units, cubic meters, cubic feets, oil barrel amongst others. I would be happy to add them, would you be open to that ?

putridparrot commented 1 year ago

I actually have some code with cubic metres, feet, inches and oil barrel, but haven't had chance to test them fully - if you would like to add to the converters feel free - the only issue is I have all the definitions in a YAML file which I use to generate all the different language versions of the code - so I'd need to take any contributions then add to the definition file (I've not made this publicly available at the moment, not had time to clean all the code up) then regenerate the source code.

happysalada commented 1 year ago

I see this might create additional work for you, no problems. Im personally not in a eush, whenever you have time is fine. Thank you for the library !

putridparrot commented 1 year ago

Added cubic metres, cubic feet, cubic inches and oil barrels. Latest version deployed to https://crates.io/crates/unit-conversions - hopefully all works as expected.

happysalada commented 1 year ago

Thanks a lot !

putridparrot commented 1 year ago

You're welcome - let's hope my tests are spot on and I've got the formula correct :)