search

puttyman / hass-amplifi

A home assistant integration for Ubiquiti Amplifi
32 stars 15 forks source link

2.1.2 bugfixes #57

Closed hawksj closed 3 months ago

hawksj commented 3 months ago

This PR is smaller than it appears. It adds a check when trying to get the list of Ethernet devices to ensure that the key exists before trying to access it.

It also gives WiFi devices that have no hostname/IP address a better friendly name by not including the amplifi_ prefix in the friendly name and capitalising the letters.

The last fix is preventing the Ethernet Port device trackers from getting a MAC attribute which was erroneously included for Ethernet Devices but is not applicable for Ports.

This resolves #55

hawksj commented 3 months ago

@atudor2 would you do me the favor of testing this update before merging changes please? It's a pretty quick one but always good to have a second opinion.

atudor2 commented 3 months ago

Hi @hawksj sorry, I seem to have missed this mention! Lgtm 👍 and didn't encounter any issues when installed my side so good to continue

hawksj commented 3 months ago

Great stuff thanks so much @atudor2. It's a shame we don't have more testers for these things but plesetsk seemed to be happy with it so I'll merge and release in the morning.