search

puuu / ESPiLight

ESPiLight - pilight 433.92 MHz protocols library for Arduino
GNU General Public License v3.0
110 stars 41 forks source link

Use GitHub tag instead own downloadURL #1

Closed ivankravets closed 8 years ago

puuu commented 8 years ago

@ivankravets Thanks for the hint and pull request. The idea of using downloadURL was to integrate files that are not directly in the git repository but in the release zip file.

The files coming from a git submodule and are integrated by a Makefile. As far as I see, there is no possibility in platfomIO/library.json to run a script (in this case only make) for generation the library download file.

Now I use a release branch as workaround. Your patch was merged with 2e961bf68918f454cc55bcdc6848cc208fd8b32a.

@ivankravets Do I need to register the new library.json again?