puuu / ESPiLight

ESPiLight - pilight 433.92 MHz protocols library for Arduino
GNU General Public License v3.0
110 stars 41 forks source link

Fix tx repeat number #32

Closed jonudewux closed 5 years ago

jonudewux commented 6 years ago

Take in to account protocol specific txrpt value. When learning code should be send then repeat number is higher than default.

puuu commented 6 years ago

Thank you for this contribution.

I see that this is a useful feature and want this feature merged, but the current implementation does not yet satisfy me:

One possibility would be to provide a default argument for tx_rep, e.g. nullptr and check it before assigning a value.

Would you please update this pull request.

puuu commented 5 years ago

@jonudewux, please have a look to #35, as a alternative implementation.

puuu commented 5 years ago

35 is merged.