Closed jonudewux closed 5 years ago
Thank you for this contribution.
I see that this is a useful feature and want this feature merged, but the current implementation does not yet satisfy me:
ESPiLight::createPulseTrain()
is a method of the public API and changing their argument list will break other programs, like it broke test_parse.ino
and test_proto_limit.ino
. One possibility would be to provide a default argument for tx_rep
, e.g. nullptr
and check it before assigning a value.
Would you please update this pull request.
@jonudewux, please have a look to #35, as a alternative implementation.
Take in to account protocol specific txrpt value. When learning code should be send then repeat number is higher than default.