puuu / ESPiLight

ESPiLight - pilight 433.92 MHz protocols library for Arduino
GNU General Public License v3.0
109 stars 41 forks source link

Calculate and use lengths according to protocols to fix issues with e.g. Nexus protocol #54

Closed enwi closed 3 years ago

enwi commented 3 years ago

Other changes featured in this PR:

enwi commented 3 years ago

Does this PR meet everything we discussed on #53 @puuu ?

puuu commented 3 years ago

Ok, looks good, but I want to do a test on an ESP first.

Can you confirm receipt of Nexus signals?

enwi commented 3 years ago

I can test it on esp32 and esp8266, but will take some time

puuu commented 3 years ago

Yes, would be great.

enwi commented 3 years ago

I can confirm that it works on ESP8266 (Wemos D1 Mini) with SRX882

RF signal arrived [nexus][103] (0) {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
RF signal arrived [nexus][103] (2) {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
Valid message: [nexus] {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
RF signal arrived [nexus][103] (3) {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
RF signal arrived [nexus][103] (3) {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
RF signal arrived [nexus][103] (3) {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
RF signal arrived [nexus][103] (3) {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
RF signal arrived [nexus][103] (3) {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
RF signal arrived [nexus][103] (3) {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
RF signal arrived [nexus][103] (3) {"id":103,"channel":0,"battery":1,"temperature":17.9,"humidity":71}
puuu commented 3 years ago

Great, that the nexus protocol works. I updated pilight in the master branch. You may can rebase to master without the pilight commits.

puuu commented 3 years ago

Thanks! I merged it into master.