puzzle / cert-manager-webhook-dnsimple

A cert-manager ACME DNS01 solver webhook for DNSimple.
Apache License 2.0
19 stars 24 forks source link

Container using privileged port 443 #19

Closed madchr1st closed 2 months ago

madchr1st commented 2 years ago

Currently the container is exposing port 443, which belongs to the privileged port range.

IMHO the use of this privileged port is unnecessary, as we can "hide" the privileged port behind a Kubernetes service.

Not using a privileged port would allow the container to be run on more restrictive container platforms, such as OpenShift.

Could you maybe make the port configurable as en environment variable?

madchr1st commented 2 years ago

See also PR 18 of the gandi webhook, which could be used as a solution. I would be happy to write the PR if you agree with the solution.

madchr1st commented 2 years ago

push @arnediekmann

dvob commented 4 months ago

this can be configured using the --secure-port option.