search

puzzle / cert-manager-webhook-dnsimple

A cert-manager ACME DNS01 solver webhook for DNSimple.
Apache License 2.0
19 stars 24 forks source link

fix: explicit pki durations to match resulting objects #5

Closed cmacrae closed 3 years ago

cmacrae commented 3 years ago

When using a GitOps deployment model, these resources are always considered "out of sync", as the resulting Certificate object's 'duration' field also specifies minutes & seconds.

These changes are essentially a no-op, but match the object, for GitOps compatability.

arnediekmann commented 3 years ago

@cmacrae thanks for the pr. I just released version 0.0.4 with your commit incorporated.

cmacrae commented 3 years ago

That was fast! Thanks @arnediekmann :)