search

puzzle / dagger-module-helm

Dagger Module providing Helm functionality
Apache License 2.0
1 stars 1 forks source link

Password should be of type Secret #21

Closed Jaxwood closed 1 week ago

Jaxwood commented 2 weeks ago

Hi,

Thanks for your module.

Currently password is handled as a string - dagger exposes a type dagger.Secret.

Using dagger.Secret would hide the password in logs.

Would it be possible to change it to type dagger.Secret?

chrira commented 2 weeks ago

Hello. Thanks for your proposal! I'll change it to a Dagger Secret.

chrira commented 1 week ago

@Jaxwood The new version v1.0.0 of the module now uses a secret for the password. I also changed to the stdin method for helm registry login.

Module: https://daggerverse.dev/mod/github.com/puzzle/dagger-module-helm/helm@03b5661b7c1c49318f9546a93d349bccdb88894d