Closed allthesignals closed 2 years ago
Looks good to me. I do not know how to test colored text either.
Prawns color tag also supports cmyk: "
I adjusted the build.yml hoping to get the checks working for the pull requests, too.
Looks good to me. I do not know how to test colored text either.
Prawns color tag also supports cmyk: "and CMYK" Do you think you could integrate this? Adding the color tag to the text semantics list in the Readme would be great, too.
I adjusted the build.yml hoping to get the checks working for the pull requests, too.
Thanks for the feedback. Yeah! I just pushed up a change. Not sure it's the most "rubyist" way. Let me know if there's a more preferred way to deal with hash destructuring :)
Great, thank you for your contribution!
I managed to get the checks running. Once rubocop is happy, I will merge your request.
Thanks, @codez! Fixed the linting issues. I saw code coverage check failed but seemed to be a configuration issue.
Hi @codez any other feedback?
Thank you for the contribution!
Addresses #15 by enabling support for Prawn core's
<color></color>
"HTML-esque" tag.A few things I'm concerned about here:
#start_color
#end_color
) in the best place. Does it make sense to translate non-HTML this way?Thanks!
Here's some manual output to show this actually seems to work...
test.pdf