Draft: dhcpv4 Module - Githubissues

puzzle / puzzle.opnsense

An Ansible Collection to configure an opnsense Firewall

https://puzzle.github.io/puzzle.opnsense/collections/puzzle/opnsense/index.html

GNU General Public License v3.0

24 stars 12 forks source link

Draft: dhcpv4 Module #84

Open ombre8 opened 7 months ago

ombre8 commented 7 months ago

Added a dhcpv4 Module, desperately looking for feedback since I honestly didn't understand everything I did :smile_cat:

ToDo:

get interface from module to config Map, aka we need a way to get module_args to xml paths (do we have that yet? or do we need to implement that?)
input validation
add more test?

closes #58

KiLLuuuhh commented 6 months ago

I would suggest renaming the file plugins/module_utils/services_dhcpv4.py to plugins/module_utils/services_dhcpv4_utils.py to be consistent with the other utils.