search

pvanallen / delft-ai-toolkit

Tool for Prototyping AI Projects
30 stars 3 forks source link

Current version of xNode causes bug #12

Closed pvanallen closed 5 years ago

pvanallen commented 5 years ago

The system is currently 20 commits back from xNode. In a test, if updated to the current xNode, it breaks ActionsEditor.cs at line 48 with two errors:

Assets/Scripts/delftToolkit/Nodes/Editor/ActionsEditor.cs(48,24): error CS1502: The best overloaded method match for `XNodeEditor.NodeEditorGUILayout.InstancePortList(string, System.Type, UnityEditor.SerializedObject, XNode.NodePort.IO, XNode.Node.ConnectionType, XNode.Node.TypeConstraint, System.Action)' has some invalid arguments

Assets/Scripts/delftToolkit/Nodes/Editor/ActionsEditor.cs(48,135): error CS1503: Argument #6' cannot convertmethod group' expression to type `XNode.Node.TypeConstraint'

pvanallen commented 5 years ago

@Siccity can you create a branch to fix this so I can test the whole system with the updated xNode?

Siccity commented 5 years ago

Yes I'll do that right away :)

Siccity commented 5 years ago

Pushed branch https://github.com/pvanallen/delft-toolkit-v2/tree/xnode-update It was just a missing extra parameter relating to a new feature. It is now a very simple task to make inputs only accept connections from matching output types. I set the actions list to 'strict', meaning it will only accept action inputs.

pvanallen commented 5 years ago

Okay, tests out fine. Go ahead and merge with master.

Siccity commented 5 years ago

Done