search

pvbrowser / pvb

HMI and SCADA
http://pvbrowser.org
Other
268 stars 152 forks source link

change qtDatabase::nextRecord() to detect end of records #2

Closed mhefr closed 11 years ago

mhefr commented 11 years ago

Hi, I'ts new for me but I can send you Pull request with GitHub. Best Regrards Matthieu

pvbrowser commented 11 years ago

Hello Matthieu,

i did not know either. But prior to your pull request i already did a push (with a comment).

Best regards: Rainer

Am 23.05.2013 12:29, schrieb mhefr:

Hi, I'ts new for me but I can send you Pull request with GitHub. Best Regrards Matthieu

    You can merge this Pull Request by running

git pull https://github.com/mhefr/pvb master

Or view, comment on, or merge it at:

https://github.com/pvbrowser/pvb/pull/2

    Commit Summary
mhefr commented 11 years ago

Hi Rainer, At the end there was no problem with the garbage collection when lua_close. This modification is compliant with the Qt recomandation http://qt-project.org/doc/qt-4.8/threads-modules.html#threads-and-the-sql-module

Could you close my pull request. Closing a pull request will not merge it. https://help.github.com/articles/closing-a-pull-request ? Best Regards Matthieu

pvbrowser commented 11 years ago

Could you close my pull request. Ok, done. Thank you for your solution with the named database connections.

Am 27.05.2013 12:45, schrieb mhefr:

Hi Rainer, At the end there was no problem with the garbage collection when lua_close. This modification is compliant with the Qt recomandation http://qt-project.org/doc/qt-4.8/threads-modules.html#threads-and-the-sql-module

Could you close my pull request. Closing a pull request will not merge it. https://help.github.com/articles/closing-a-pull-request ? Best Regards Matthieu

— Reply to this email directly or view it on GitHub https://github.com/pvbrowser/pvb/pull/2#issuecomment-18492835.