search

pvcnt / mergeable

A better inbox for GitHub pull requests
https://pvcnt.github.io/mergeable/
MIT License
35 stars 6 forks source link

feat: CI to publish helm chart #10

Closed ts-mini closed 7 months ago

ts-mini commented 8 months ago

dependent on #7 - just an opinionated approach to publishing helm charts, but using github first this time

pvcnt commented 8 months ago

Hi! I tested this workflow file and came up with some changes. I removed helm-docs (I didn't get how it was used?), and replaced the helm releaser by a plain and simpler helm package call. It is also only pushing to ghcr.io. It is installed with the following command:

helm upgrade --install reviewer oci://ghcr.io/pvcnt/helm/reviewer --version ${version}

I validated this in a test branch and its does seem to work. Since I pushed changes to your branch, please let me know what you think of it! Does it fit your use case? Do you also need the publication of a relase on GitHub + publication on gh-pages, like what the chart-releaser-action was doing? I'd like to understand your workflow, and where would you like to install the Helm chart from.

ts-mini commented 7 months ago

Hi! I tested this workflow file and came up with some changes. I removed helm-docs (I didn't get how it was used?), and replaced the helm releaser by a plain and simpler helm package call. It is also only pushing to ghcr.io. It is installed with the following command:

helm upgrade --install reviewer oci://ghcr.io/pvcnt/helm/reviewer --version ${version}

I validated this in a test branch and its does seem to work. Since I pushed changes to your branch, please let me know what you think of it! Does it fit your use case? Do you also need the publication of a relase on GitHub + publication on gh-pages, like what the chart-releaser-action was doing? I'd like to understand your workflow, and where would you like to install the Helm chart from.

honestly I keep forgetting you can do oci images - there this is totally fine. The use case was "i dont want to clone and install from local dir" and this completely solves that.

sorry for the late reply!

pvcnt commented 7 months ago

Let's merge this, then. Thank you!