pvcnt / mergeable

A better inbox for GitHub pull requests
https://mergeable.pages.dev
MIT License
12 stars 3 forks source link

fix(filter): `repo:foo/bar` doesn't apply to the section #48

Closed davinkevin closed 1 week ago

davinkevin commented 2 weeks ago

Hi 👋

I just started using this project for my own management and I discovered the repo:gradle/dv filter doesn't work/apply.

If I set a section with a filter, every PR still shows up. It's the same if I put an imaginary and non existing repo, like repo:foo/bar (which should display nothing IIUC).

Thank you

pvcnt commented 2 weeks ago

Hi @davinkevin! Could you please share the exact configuration of your section? I experimented with the following queries: repo:apache/solr and repo:apache/solr involves:@me and both showed me what I was expecting. Also, could you please confirm that your Personal Access Token has access to this repository?

davinkevin commented 1 week ago

My configuration looks like this:

Panel query: is:open is:pr "This PR has been generated by Renovate Bot" repo:foo/bar

My connection configuration:

image

Even if I've modified my org by foo and the repo I would like to focus with bar, you can see I have another called bar-support (the pattern is the same, I just replaced the name).

pvcnt commented 1 week ago

Ok, I see, it looks like specifying both org: (implicitly added via the org filter in the connection specification) and repo: does not work as expected, with the latter being ignored. I can provide a fix for this edge case.

Unrelated question, but seizing the opportunity to know how people use this project: how is it deployed? Docker, Helm, static build, other?

davinkevin commented 1 week ago

I use the helm version (even if as an ops I don't like helm 😅), and it's deployed using GitOps here

pvcnt commented 1 week ago

It should be fixed by now! Could you please confirm, if you have the opportunity to?

And I'm glad you're using the Helm deployment. I will shortly move to a more traditional client/server model (because having only an SPA is too limited), but anyone relying on the Docker image or Helm Chart should be able to upgrade seemlessly.

davinkevin commented 1 week ago

It's working!

image

I have just two, not three!

Thx!