search

pvcnt / mergeable

A better inbox for GitHub pull requests
https://mergeable.pages.dev
MIT License
12 stars 3 forks source link

feat: helm chart #7

Closed ts-mini closed 5 months ago

ts-mini commented 5 months ago

Note: Doing some final testing, but wanted to get this infront of you to see if you're amenable

Actions Required

pvcnt commented 5 months ago

Thank you for opening this PR! Out of curiosity, are you trying to deploy this project somewhere?

Regarding the container hosting provider, I would favour GitHub's Container registry, which is the simplest to set up and does not require any external account. I just created a workflow, an image is now pushed for every merge in the main branch, and tagged after the latest commit sha. Details are here https://github.com/pvcnt/reviewer/pkgs/container/reviewer

Regarding the Helm itself, I assume it comes from a template? I would prefer if you could clean it up a bit (e.g., by removing commented blocks and what is in tests).

ts-mini commented 5 months ago

Thank you for opening this PR! Out of curiosity, are you trying to deploy this project somewhere?

Yeah playing with it internally at my work. On a few different teams now with the need to filter various PRs with various SLAs and the /pulls wasn't cutting it for me

Regarding the container hosting provider, I would favour GitHub's Container registry, which is the simplest to set up and does not require any external account. I just created a workflow, an image is now pushed for every merge in the main branch, and tagged after the latest commit sha. Details are here https://github.com/pvcnt/reviewer/pkgs/container/reviewer

Totally fine - just picked a solution at random and figured I'd see where it'd land

Regarding the Helm itself, I assume it comes from a template? I would prefer if you could clean it up a bit (e.g., by removing commented blocks and what is in tests).

Yup! This is the result of helm create x with little changes - I can make it a bit more opinionated and clean, nbd

pvcnt commented 5 months ago

Cool! This also came from a need at my work, which was to follow PRs across several instances of GitHub.

ts-mini commented 5 months ago

sorry was swamped a bit - took some time to clean it up

pvcnt commented 5 months ago

I fixed an issue reported by helm lint, and validated I can install it locally. Merging this, thank you!