search

pvcy / presidio

MIT License
0 stars 0 forks source link

Automate syncing public/private Presidio forks with upstream repo #9

Closed willsthompson closed 2 years ago

willsthompson commented 4 years ago

We want to keep our private fork of Presidio up to date with changes made to Microsoft's repo. It is not possible in GitHub to fork a public repo and make it private, so our "private fork" is really just a clone, and that does not benefit from the automatic tracking of a true fork.

  1. Use pull to automatically generate PRs to sync the public repo with our public fork.
  2. Similarly use pull to pull our public fork's master into a sync branch on the private repo and rebase it's master with the sync branch (always maintaining a history with our private modifications in front of the public master commits), then issue a PR.
willsthompson commented 3 years ago

Iceboxing this until Presidio plan is worked out.

In Plan A, we are able to use the public Presidio following updates from them to support JSON. This will require a significant refactoring project to 1) port our new recognizers to their JSON-based system and 2) rewrite our Presidio post-processing to accept the new input.

In Plan B, we simply make our fork public. Our recognizers have already been migrated into the privacy-api repo, and (AFAIK) nothing left in the fork is strategic to us.

willsthompson commented 2 years ago

We'll either go with Plan B or, ideally, Presidio 2.0 implements enough features that we don't need to fork at all.