search

pviswanathan / ChromeAutoTextExpander

Google Chrome Extension : Auto Text Expander - listens for keypresses on pages that support it and will auto-replace text as you type. Keywords: javascript jquery chrome text expander replacement.
MIT License
158 stars 46 forks source link

Add support for Zendesk Inbox #17

Closed takeo closed 8 years ago

takeo commented 8 years ago

Zendesk Inbox recently moved to a wysiwyg editor that uses an iframe, so I updated this with the same special tweaks that other sites with iframe based editors have.

carlinyuen commented 8 years ago

Thanks Toby! Let me check this out and get back to you this week.

.C On Feb 19, 2016 8:22 PM, "Toby Sterrett" notifications@github.com wrote:

Zendesk Inbox recently moved to a wysiwyg editor that uses an iframe, so I updated this with the same special tweaks that other sites with iframe

based editors have.

You can view, comment on, or merge this pull request online at:

https://github.com/carlinyuen/ChromeAutoTextExpander/pull/17 Commit Summary

  • Add support for Zendesk Inbox

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/carlinyuen/ChromeAutoTextExpander/pull/17.

carlinyuen commented 8 years ago

Hey Toby, this looks pretty good! Have you tested this by any chance? If not, I'll try to get around to testing it this weekend and then doing the official merge if all looks well. Figured you may be better positioned to test it if you already have access to ZenDesk and such.

takeo commented 8 years ago

Hey @carlinyuen, yup, it's working. Here's a gif of me using it with my PR version of the extension installed in my Chrome:

It's using TinyMCE, so it's pretty much the exact same setup (and behavior, I assume) as atlassian.net

carlinyuen commented 8 years ago

Awesome. I'll pull it in and push an update this weekend, much appreciated!

. Carlin ............................................ Product . Design . Development e : email.me@carlinyuen.com

: +1 (234) 567-9763

On Fri, Feb 26, 2016 at 12:05 PM, Toby Sterrett notifications@github.com wrote:

Hey @carlinyuen https://github.com/carlinyuen, yup, it's working. Here's a gif of me using it with my PR version of the extension installed in my Chrome:

https://camo.githubusercontent.com/727c6f96e833e797c16d64b296cbef7c73ee0521/687474703a2f2f636c2e6c792f313932783177326b304b33532f53637265656e2532305265636f7264696e67253230323031362d30322d3236253230617425323030382e3538253230414d2e676966

It's using TinyMCE, so it's pretty much the exact same setup (and behavior, I assume) as atlassian.net

— Reply to this email directly or view it on GitHub https://github.com/carlinyuen/ChromeAutoTextExpander/pull/17#issuecomment-189374554 .