pvjohnson / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

duplication in lib list on chromium link #192

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
We probably are not fully dedupping lib in gyp, particularly if they come from 
msvs_settings.
We should.

From email from robertshield:

I noticed something odd in the .vcproj files generated by .gyp for a couple of 
different targets. I thought I'd ask you two about it since I think you've done 
.gyp work recently, if there's a mailing list I could send this to, please let 
me know.

  For chrome_frame_tests.vcproj and remoting_unittests.vcproj, the AdditionalDependencies files in the generated .vcproj files have many duplicates of the same input libs. For example,

secur32.lib
iphlpapi.lib
crypt32.lib

are included multiple times (around 14 to 17 times each) on the linker command 
line which doesn't look right. 

I poked around a bit and the only place I can see a reference to all three of 
these is in chrome_dll.gypi:25 declaring the corresponding DLLs as delay-load 
dependencies of chrome.dll.  I'm not sure how this would result in their 
duplication though.

Original issue reported on code.google.com by bradnel...@chromium.org on 10 May 2011 at 1:49