Open GoogleCodeExporter opened 9 years ago
Hint: I do use src/.gyp/include.gypi for that, and run:
$ HOME=`pwd` gclient runhooks
to rebuild the makefiles
HTH
Original comment by gli...@google.com
on 17 May 2011 at 1:14
I know about your workaround
but I'd rather have an official solution :)
Original comment by timurrrr@google.com
on 17 May 2011 at 1:48
So current build/gyp_chromium injects a bunch of -I options.
I'd be amenable to signing a CL that checks for the presence of something like
src/client_options.gypi and if it exists, adds -I to the command line. We do
something similar already for supplemental components (like pdf).
In fact if you want to do this with zero code change, if you create a
src/chrome/supplement.gypi that will get included automatically.
In fact that's probably a good way to do this. Sound ok?
Original comment by bradnelson@google.com
on 18 May 2011 at 12:04
> src/chrome/supplement.gypi
Ha, didn't know about this - thanks!
FTR, this is done by including all src/*/supplement.gypi from the
build/gyp_chromium file.
-> that's enough for *me*.
However, I believe the feature will be useful if it was present without any
.gyp file modifications.
Original comment by timurrrr@chromium.org
on 18 May 2011 at 9:18
What do you mean without any gyp file modifications?
You mean if it were part of gyp rather than gyp_chromium ?
Original comment by bradnelson@google.com
on 18 May 2011 at 5:11
Yes, exactly
Original comment by timurrrr@google.com
on 18 May 2011 at 5:26
Original issue reported on code.google.com by
timurrrr@chromium.org
on 17 May 2011 at 11:59