pvjohnson / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Add project-level include.gypi overrides #195

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Use-case:
two checkouts of Chromium, one for Valgrind builds and the other for 
performance testing.

The former requires ~/.gyp/includes.gypi or GYP_DEFINES,
the latter requires a 'clean' setup.

Original issue reported on code.google.com by timurrrr@chromium.org on 17 May 2011 at 11:59

GoogleCodeExporter commented 9 years ago
Hint: I do use src/.gyp/include.gypi for that, and run:
 $ HOME=`pwd` gclient runhooks
to rebuild the makefiles

HTH

Original comment by gli...@google.com on 17 May 2011 at 1:14

GoogleCodeExporter commented 9 years ago
I know about your workaround
but I'd rather have an official solution :)

Original comment by timurrrr@google.com on 17 May 2011 at 1:48

GoogleCodeExporter commented 9 years ago
So current build/gyp_chromium injects a bunch of -I options.
I'd be amenable to signing a CL that checks for the presence of something like 
src/client_options.gypi and if it exists, adds -I to the command line. We do 
something similar already for supplemental components (like pdf).

In fact if you want to do this with zero code change, if you create a 
src/chrome/supplement.gypi that will get included automatically.

In fact that's probably a good way to do this. Sound ok?

Original comment by bradnelson@google.com on 18 May 2011 at 12:04

GoogleCodeExporter commented 9 years ago
> src/chrome/supplement.gypi
Ha, didn't know about this - thanks!
FTR, this is done by including all src/*/supplement.gypi from the 
build/gyp_chromium file.
-> that's enough for *me*.

However, I believe the feature will be useful if it was present without any 
.gyp file modifications. 

Original comment by timurrrr@chromium.org on 18 May 2011 at 9:18

GoogleCodeExporter commented 9 years ago
What do you mean without any gyp file modifications?
You mean if it were part of gyp rather than gyp_chromium ?

Original comment by bradnelson@google.com on 18 May 2011 at 5:11

GoogleCodeExporter commented 9 years ago
Yes, exactly

Original comment by timurrrr@google.com on 18 May 2011 at 5:26