pvjohnson / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Gyp may generate invalid VS2010 solution file #212

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Set PATH to gyp, python, and msbuild.
2. Extract the attached gyp files.
3. > cd gyp_test\repro
4. > call gyp --depth=. base\base.gyp build\build.gyp -G msvs_version=2010
5. > msbuild build\build.sln

What is the expected output? What do you see instead?
 Expected output: Build succeeds.
 Actual output: following error message.
| d:\work\repro>msbuild build\build.sln
| Microsoft (R) Build Engine Version 4.0.30319.1
| [Microsoft .NET Framework, Version 4.0.30319.237]
| Copyright (C) Microsoft Corporation 2007. All rights reserved.
| 
| Build started 2011/08/22 16:54:34.
| d:\work\repro\build\build.sln(5): Solution file error MSB5006: Error parsing 
project section for project "(build)". The project file name is empty.
|
| Build FAILED.
|
|   d:\work\repro\build\build.sln(5): Solution file error MSB5006: Error 
parsing project section for project "(build)". The project file name is empty.
| 
|     0 Warning(s)
|     1 Error(s)
|
| Time Elapsed 00:00:00.63

What version of the product are you using? On what operating system?
Build fails as follows.
- gyp r1007
- OS Windows 7 x64

Please provide any additional information below.
 As attached zip file, gyp r1007 generates following lines in the solution file in this case.
| Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "(build)", "", 
"{BC1FC5DA-9C54-7D77-0BFF-DEDDFD7A8F6C}"
| EndProject

However, it seems that msbuild cannot handle these lines as error message says.

On the other hand, Visual Studio 2010 generates the following solution file for 
a folder project.
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "(build)", "(build)", 
"{BC1FC5DA-9C54-7D77-0BFF-DEDDFD7A8F6C}"
EndProject

After I update the solution file manually, msbuild can handle the solution file 
well.

Original issue reported on code.google.com by yukawa@google.com on 22 Aug 2011 at 8:16

Attachments:

GoogleCodeExporter commented 9 years ago
Now the length of folder name is more than one because any null folder name 
becomes '.' by r1026.
So please change the status to 'fixed'.

Original comment by yukawa@google.com on 3 Sep 2011 at 10:00

GoogleCodeExporter commented 9 years ago

Original comment by bunge...@chromium.org on 4 Oct 2011 at 1:54