search

pvjohnson / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

xcode generator attempts to add libraries to FrameworksPhase even when target.type: 'none' #237

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
This problem is occurring in the node.js gyp build.

The problem is that a target_defaults.libraries is set up for a linked series 
of gyp projects, and this is inherited for all targets in all projects.

There is then a target that does not generate a binary - with type: 'none' - 
but the presence of the libraries attribute triggers the code at:

http://code.google.com/p/gyp/source/browse/trunk/pylib/gyp/generator/xcode.py#11
64

Should there be a test here to process these libraries only when type != 
'none'? Or should those targets explicitly do something to override the 
target_defaults ?

A suggested change is here:

https://github.com/paddybyers/node/commit/64fc8b2dfdaded482779cfd56eddea28f8dd0c
bd

Original issue reported on code.google.com by paddy.by...@gmail.com on 16 Nov 2011 at 12:33