pvjohnson / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

there's a problem with relative-path includes on windows #240

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I've tripped over this in a webkit-only checkout of chromium:

https://bugs.webkit.org/show_bug.cgi?id=74323

if you are Source\WebKit\chromium directory on Windows, such that gyp is 
checked out into .\tools\gyp, and you have the following files:

D:\src\wk\Source\WebKit\chromium>type DRT.gyp
{
    'targets': [
        {
            'target_name': 'DumpRenderTree',
            'type': 'executable',
            'dependencies': [
                '../chromium/build/temp_gyp/googleurl.gyp:googleurl',
                'base/base.gyp:base',
            ],
            'sources': [
                'DumpRenderTree.h',
            ],
        },
    ],
}

D:\src\wk\Source\WebKit\chromium>type build\temp_gyp\googleurl.gyp
{
  'targets': [
    {
      'target_name': 'googleurl',
      'type': 'static_library',
      'dependencies': [
        '../../base/base.gyp:base',
      ],
      'sources': [
        'gurl.cc',
      ],
    },
  ],
}

D:\src\wk\Source\WebKit\chromium>type base\base.gyp
{
  'targets': [
    {
      'target_name': 'base',
      'type': 'static_library',
      'sources': [
        'md5.cc',
      ],
    },
  ],
}

D:\src\wk\Source\WebKit\chromium>tools\gyp\gyp.bat DRT.gyp
<here you get some complaints about missing files ...>

D:\src\wk\Source\WebKit\chromium>start DRT.sln

you will get complaints about two copies of the 'base' project being included 
in the solution. If you replace '../chromium' with '.' in DRT.gyp, the problem 
goes away.

Bradley was watching over my shoulder as I reduced the problem to this. We're 
both kinda dumbfounded.

Original issue reported on code.google.com by dpranke@chromium.org on 13 Dec 2011 at 2:49

GoogleCodeExporter commented 9 years ago

Original comment by dpranke@chromium.org on 13 Dec 2011 at 2:49

GoogleCodeExporter commented 9 years ago

Original comment by dpranke@chromium.org on 13 Dec 2011 at 2:50

GoogleCodeExporter commented 9 years ago
Fixed in http://code.google.com/p/gyp/source/detail?r=1105 (and r1107).

Original comment by dpranke@chromium.org on 15 Dec 2011 at 1:36