search

pvjohnson / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

[Patch] FIX pylib/gyp/common.py recognize new version of FreeBSD. #249

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
* What steps will reproduce the problem?

1. pylib/gyp/common.py line 354, freebsd7,8 as freebsd, but freebsd9,10 is not 
recognized. 

* What is the expected output? What do you see instead?

recognize freebsd* as freebsd. I see current code will return linux on freebsd9 
and 10

* What version of the product are you using? On what operating system?

svn trunk, FreeBSD 10

* Please provide any additional information below.

Please see my patch, thanks!

Original issue reported on code.google.com by lin...@gmail.com on 8 Feb 2012 at 1:40

Attachments:

GoogleCodeExporter commented 9 years ago 
While the issue (bug) is legit, this is also not the right place to attach the 
patch.

You should use similar instructions to 
http://code.google.com/p/skia/wiki/ContributingHowto to upload the patch to 
http://codereview.chromium.org/ for review. http://code.google.com/p/gyp/... is 
not the right place to attach patches.

Original comment by thestig@chromium.org on 8 Feb 2012 at 3:06

GoogleCodeExporter commented 9 years ago 
Thanks, but I'm sorry that I still don't know how to do it. I'll ask for
others help.

Original comment by lin...@gmail.com on 8 Feb 2012 at 3:24

GoogleCodeExporter commented 9 years ago 
Hello,

    Do you mean follow the steps just like it?
    http://code.google.com/p/skia/wiki/ContributingHowto#Submitting_a_patch

2012/2/8 Daniel Lin <linpct@gmail.com>

Original comment by lin...@gmail.com on 8 Feb 2012 at 3:34

GoogleCodeExporter commented 9 years ago 
linpct: Yes, the steps outlined in Submitting a patch.  Specifically, you need 
to use gcl or git cl to upload the patch to the codereview website.

Original comment by tony@chromium.org on 8 Feb 2012 at 10:43

GoogleCodeExporter commented 9 years ago 
Thanks, I'll try that.  :-)

Original comment by lin...@gmail.com on 9 Feb 2012 at 12:25

GoogleCodeExporter commented 9 years ago 
So... did this ever go through? I think bug 251 is the same issue, but their 
patch is better.

Original comment by thestig@chromium.org on 9 Mar 2012 at 8:15

GoogleCodeExporter commented 9 years ago 
Hi,

    I have no idea why their patch is better, but just go and patch it
using patches you like, it just fix issues. :-)

Original comment by lin...@gmail.com on 12 Mar 2012 at 5:03