MSBuild: targets of rules don't depend on rules' inputs

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Apply https://chromiumcodereview.appspot.com/10358006 on a machine with 
VS2010
2. python gyptest.py -f msvs test/rules-rebuild/gyptest-default.py
3. fail to profit.

The CL expands the existing rules-rebuild test by having it modify the "input" 
to the rule.  This should cause the targets to be considered out of date (and 
does for VS2008/VCBuild projects), but doesn't.  This is a problem for things 
like the chrome_version_resources target in Chromium: VERSION changes, yet the 
*_version.rc files aren't rebuilt.

Original issue reported on code.google.com by grt@chromium.org on 3 May 2012 at 3:25

[GoogleCodeExporter]

Original comment by grt@chromium.org on 8 May 2012 at 4:14

• Changed state: Started

[GoogleCodeExporter]

Fixed in r1365

Original comment by grt@chromium.org on 8 May 2012 at 8:20

• Changed state: Fixed

[GoogleCodeExporter]

Commit: 1d54fed606d6115ae3cc3bb4c55ded088aed0c95
 Email: grt@chromium.org@78cadc50-ecff-11dd-a971-7dbc132099af

Fixup dependencies in rules for VS2010 (MSBuild).

VS2010 uses some file tracking juju in various .tlog files to do reality-based 
dependency tracking.  Custom rules don't use this magic, so the dependency 
between a rule's inputs and its target is lost.  This change causes a 
foo.read.1.tlog file to be generated.  This file contains the list of 
additional dependencies for each primary input file.

BUG=gyp:263
TEST=python gyptest.py -f msvs test/rules-rebuild/gyptest-default.py
Review URL: https://chromiumcodereview.appspot.com/10358006

git-svn-id: http://gyp.googlecode.com/svn/trunk@1365 
78cadc50-ecff-11dd-a971-7dbc132099af

M   pylib/gyp/generator/msvs.py
M   test/rules-rebuild/gyptest-default.py

Original comment by bugdroid1@chromium.org on 8 May 2012 at 10:59