pvjohnson / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

With pylint installed, presubmit checks produce a spew of warnings #269

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Gyp's presubmit checks ask that I install pylint, but if I install Ubuntu 
Lucid's pylint I get 6000 lines of warning spew that are not relevant to the 
small Gyp change I was making.

Here's what happens:

$ git cl dcommit
Loaded authentication cookies from /home/mseaborn/.codereview_upload_cookies
Running presubmit commit checks ...

** Presubmit ERRORS **
Please install pylint with "sudo apt-get install python-setuptools; sudo 
easy_install pylint"
or visit http://pypi.python.org/pypi/setuptools.
Cannot do static analysis of python files.

$ sudo apt-get install pylint
$ git cl dcommit 2>&1 | tee log
Exception RuntimeError: 'maximum recursion depth exceeded while calling a 
Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a 
Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a 
Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a 
Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded in __subclasscheck__' 
in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded in __subclasscheck__' 
in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a 
Python object' in <type 'exceptions.RuntimeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded in __subclasscheck__' 
in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded in __subclasscheck__' 
in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a 
Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a 
Python object' in <type 'exceptions.AttributeError'> ignored
Loaded authentication cookies from /home/mseaborn/.codereview_upload_cookies
Running presubmit commit checks ...
************* Module PRESUBMIT
C0103: 13:CheckChangeOnUpload: Invalid name "CheckChangeOnUpload" (should match 
[a-z_][a-z0-9_]{2,30}$)
C0111: 13:CheckChangeOnUpload: Missing docstring
W0622: 22:CheckChangeOnCommit: Redefining built-in 'license'
C0103: 20:CheckChangeOnCommit: Invalid name "CheckChangeOnCommit" (should match 
[a-z_][a-z0-9_]{2,30}$)
C0111: 20:CheckChangeOnCommit: Missing docstring
C0103: 50:GetPreferredTrySlaves: Invalid name "GetPreferredTrySlaves" (should 
match [a-z_][a-z0-9_]{2,30}$)
C0111: 50:GetPreferredTrySlaves: Missing docstring
************* Module buildbot_run
W0511: 44: TODO(bradnelson): remove this when this issue is resolved:
W0511: 89: TODO(bradnelson): once the annotator supports a postscript (section 
for
W0622: 28:GypTestFormat: Redefining built-in 'format'
C0103: 28:GypTestFormat: Invalid name "GypTestFormat" (should match 
[a-z_][a-z0-9_]{2,30}$)
C0103: 65:GypBuild: Invalid name "GypBuild" (should match 
[a-z_][a-z0-9_]{2,30}$)
C0111: 65:GypBuild: Missing docstring
************* Module gyptest
W0311: 76: Bad indentation. Found 9 spaces, expected 8
W0311:134: Bad indentation. Found 4 spaces, expected 2
W0311:135: Bad indentation. Found 4 spaces, expected 2
W0311:136: Bad indentation. Found 6 spaces, expected 4
W0311:137: Bad indentation. Found 8 spaces, expected 6
W0311:138: Bad indentation. Found 6 spaces, expected 4
W0311:140: Bad indentation. Found 4 spaces, expected 2
W0311:141: Bad indentation. Found 4 spaces, expected 2
...

$ wc -l log
6241 log

Original issue reported on code.google.com by mseaborn@chromium.org on 17 May 2012 at 12:02

GoogleCodeExporter commented 9 years ago
Fixing here:
https://chromiumcodereview.appspot.com/10399131/

Original comment by bradnelson@google.com on 22 May 2012 at 9:01