Json tmlanguage format - Githubissues

pvl / abap.tmbundle

TextMate support for ABAP

20 stars 9 forks source link

Json tmlanguage format #11

Closed FreHu closed 6 years ago

FreHu commented 6 years ago

I am providing a json format since it is easier to both write and read. Converted using https://github.com/Togusa09/vscode-tmlanguage/ The extension can be used to convert back as well.

(I got around the whitespace issue of the extension by removing all whitespace from regexes first)

larshp commented 6 years ago

Hi, Both pull requests changes 600+ lines in the source, which makes it difficult to review, can we take it one step at a time?

FreHu commented 6 years ago

Hi,

the XML changes are formatting only and the json is an automatic conversion from the XML.

FreHu commented 6 years ago

I could split this into the following:

remove regex whitespace
fix indentation (the first should be one tab further, which changes the whole file)
json conversion
adding abstract keyword is just one word. I didn't intend to have it in this PR, I messed up with git somehow. I could go over more missing keywords and submit them at once.