pvlib / pvanalytics

Quality control, filtering, feature labeling, and other tools for working with data from photovoltaic energy systems.
https://pvanalytics.readthedocs.io
MIT License
97 stars 32 forks source link

Address various deprecations and test issues with pandas 2.2.0 #203

Closed kandersolar closed 9 months ago

kandersolar commented 10 months ago

A recent run of the test suite reported 262 warnings, mostly these deprecation warnings from pandas:

Fixing the first couple is a find/replace exercise. The others needed minor code rewrites.

kperrynrel commented 9 months ago

@kandersolar went ahead and added updates to the documentation gallery examples that handle the T->min conversion

kperrynrel commented 9 months ago

This is preemptive, but should I include pyarrow as a package dependency and not just a doc dependency because of this? image This would be in PR https://github.com/pvlib/pvanalytics/pull/202

kperrynrel commented 9 months ago

Otherwise LGTM!

kandersolar commented 9 months ago

This is preemptive, but should I include pyarrow as a package dependency and not just a doc dependency because of this?

No action needed on our part, I think. That is just pandas giving users a heads up that someday pip install pandas will bring pyarrow along with it, and that could cause problems in some situations (e.g. small computing environments where an additional heavy-ish dependency like pyarrow might be an unwelcome surprise). Doesn't matter for us, although I guess the warning message is a minor nuisance :P