Open kandersolar opened 4 months ago
Looks like a long-standing issue in the CEC data, where "Technology" has been "Thin film" for First Solar products from Series 4 and earlier since 2018 (archive here).
Maybe this could be better addressed in the processing of CEC data to the SAM file? @janinefreeman
@cpaulgilman FYI. I just took a look at this in SAM, and it appears that we may be having a similar problem- module technologies listed as "thin film" in the database are getting assigned to a default type for 6par_celltech
. At a cursory glance, that input seems to only inform the initial guesses for some of the parameter solution functions in 6par_solve.h
, so I'm not sure it's affecting SAM outputs per se. Would it be possible to map FirstSolar modules to cdte in our processing of the CEC data? I know we've had problems trying to correct things based on names before...
Would it be possible to map FirstSolar modules to cdte in our processing of the CEC data? I know we've had problems trying to correct things based on names before...
@janinfreeman In SSC, 6par_celltech
is an input to the 6parsolve parameter solver module, not to the module model itself, so I agree that does not affect the module model outputs.
In SAM, the module model does not use the "Technology" value shown in the module library for the "CEC Performance Model with Module Database" option on the Module page. The cell type 6par_celltech
is a user-provided input for the "CEC Peformance Model with User Entered Specifications" option. When users use the Copy specifications... button for the User Entered Specifications option to copy data from the Module Database option's library for a module with Technology = Thin Film, the SAM UI sets 6parcelltech = 2
(CdTe). So, for that specific workflow, the cell type for all First Solar modules does get set CdTe.
Here's a screenshot of the LK script from the SAM UI callback for the CEC Performance Model with User Entered Specifications input form:
Finally, in the module library for SAM 2023.12.17, First Solar modules with model numbers between FS-267 and FS-4122 are listed as "Thin Film." Model numbers FS-6385 to FS 7640 are listed as "CdTe," reflecting the way they are identified in the CEC Excel workbook. I'm hesitant to modify our library scripts to treat a particular manufacturer, or range of model numbers within a manufacturer, differently than others.
The scripts and files we use to create the SAM module libraries are here: https://github.com/NREL/SAM/tree/patch/samples/CEC%20Module%20and%20Inverter%20Libraries/CEC%20Modules
Describe the bug Some First Solar modules are incorrectly inferred to be CIGS instead of CdTe. This is because the CEC database we currently include in pvlib lists these modules as "Thin Film", which
pvlib.pvsystem.Array
maps to CIGS:https://github.com/pvlib/pvlib-python/blob/923e025dd32a05ad7c9beaa442d2b83a7be53731/pvlib/pvsystem.py#L1024-L1031
To Reproduce
That means that ModelChains using the first solar spectral correction model will incorrectly use CIGS parameters instead of CdTe parameters for these modules.
Expected behavior First Solar modules should be inferred as CdTe, not CIGS.
Versions:
pvlib.__version__
: 0.10.3Additional context These modules are still listed as
Thin Film
in the latest version of the CEC table from SAM: https://github.com/NREL/SAM/blob/patch/deploy/libraries/CEC%20Modules.csv, so updating our table won't fix this problem.