search

pvlib / pvlib-python

A set of documented functions for simulating the performance of photovoltaic energy systems.
https://pvlib-python.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.17k stars 992 forks source link

Unused fixture input in a fixture #2105

Closed echedey-ls closed 1 month ago

echedey-ls commented 3 months ago

Was the following piece of code supposed to use it's input?

https://github.com/pvlib/pvlib-python/blob/55e0a36fac1e3931b92f5f11508f6c09d903e0cc/pvlib/tests/test_irradiance.py#L61C1-L65C30

My suggestion is to remove the input parameter; I've run the tests without it and that works locally.

I suppose it's not a big deal, and for the same reason, another nice good first contribution.

wholmgren commented 3 months ago

I think it's a holdover from when dni_et (and other inputs) were calculated inputs rather than fixed inputs to various tests. It was easy to get started with calculated inputs but we eventually realized that led to unhealthy coupling in the test suite. So, safe to remove the unused fixture there.

Clemo97 commented 2 months ago

Was this issue fixed??

echedey-ls commented 2 months ago

Hi @Clemo97 !

No, it hasn't. Would you like to work on this?

I recommend reading the how to contribute page https://pvlib-python.readthedocs.io/en/stable/index.html

And this amazing post from @kurt-rhee https://kurt-rhee.github.io/2024/06/13/how-to-contribute-to-pvlib

We would be happy to help you get involved :)